Subject: Re: !console on Sun 4
To: Julian Coleman <jdc@coris.demon.co.uk>
From: Valeriy E. Ushakov <uwe@ptc.spbu.ru>
List: port-sparc
Date: 10/09/2002 02:25:49
On Tue, Oct 08, 2002 at 22:53:05 +0100, Julian Coleman wrote:

> Is this the correct fix (it makes things work) :
> 
> --- zs.c.dist	Sun Aug 25 11:04:43 2002
> +++ zs.c	Tue Oct  8 22:47:29 2002
> @@ -368,6 +368,8 @@
>  			 * sake of the comparison here.
>  			 */
>  			paddr |= 0xf0000000;
> +		/* We're just comparing the address (not the iospace) here */
> +		paddr = BUS_ADDR_PADDR(paddr);
>  		zsc->zsc_promunit =
>  			(paddr == 0xf1000000) ? 0 :
>  			(paddr == 0xf0000000) ? 1 :

Yes, this is correct.  Only I'd move BUS_ADDR_PADDR before the
preceding "if" that tests for CPUTYP_4_100.

Unfortunately, after bus_addr_t has been promoted to 64-bit we have
inconsistent names in arch/sparc when things that are bus_addr_t are
named paddr.

SY, Uwe
-- 
uwe@ptc.spbu.ru                         |       Zu Grunde kommen
http://www.ptc.spbu.ru/~uwe/            |       Ist zu Grunde gehen