Subject: Re: Strange errors from qec in Sparc Classic
To: <>
From: David Laight <david@l8s.co.uk>
List: port-sparc
Date: 01/22/2002 18:04:40
> Thanks, I added "sc->sc_debug" to qe.c and that cleared it up.

Looking at ths driver it isn't as well written as it might be :-)

1) The end-of-tx interrupt path is significantly longer that necessary
99% of the time - because it always calls qestart.
2) Better still only enable the TX interrupt when tx flow controlled. 
Saving 1 interrupt per tx packet is almost certainly measurably faster
3) qeintr should (probably) return 1 if it gets past the 'if (!(qecstat
& 0xf)) return 0;' bit - otherwise you migth get a 'splurious interrupt'
message from the interrupt dispatcher.
4) kill the '(idx % sc->sc_rb.rb_nrbuf)', division by a variable takes
weeks!

Definitely not up to my standard :-)

	David