Re: openpam build breaks on sgimips

[Rafal Boni <rafal%pobox.com@localhost>]

On Thu, Jan 31, 2008 at 12:59:49AM +0900, Izumi Tsutsui wrote:
> rafal%pobox.com@localhost wrote:
> 
> >     all ===> libpam
> >     pam_ssh.c:(.text+0x938): multiple definition of `pam_sm_authenticate'
>  :
> > Any clues appreciated... haven't had a chance to dig into it yet.. it does
> > look like the same sources built fine for sparc64, however.
> 
> This is because src/dist/openpam/include/security/openpam.h
> assumes __PIC__ means shlib targets but it is not true on mips.
> (that's the reason why we have both CSHLIBFLAGS and CPICFLAG)
> 
> The attached patch works for me, but I wonder if we should remove
> the !defined(__PIC__) check completely or not.

Ugh, that (ab)use of __PIC__ is pretty gross.  It seems the right way to
do this is to have the Makefile explicitly signal the build type (shared
vs. static)... I think that's what it did before the upgrade, no?

Thanks for looking into this... I hadn't gotten back to it yet..

--rafal