Subject: Disable pci_addr_fixup printf
To: None <port-sgimips@NetBSD.org>
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
List: port-sgimips
Date: 12/10/2005 16:18:37
Now most PCI devices on O2 work properly, so is it okay to disable
printfs for pci_addr_fixup info, which might confuse some users?
---
Izumi Tsutsui
Index: mace/pci_mace.c
===================================================================
RCS file: /cvsroot/src/sys/arch/sgimips/mace/pci_mace.c,v
retrieving revision 1.5
diff -u -r1.5 pci_mace.c
--- mace/pci_mace.c 29 Sep 2004 04:06:52 -0000 1.5
+++ mace/pci_mace.c 10 Dec 2005 06:36:48 -0000
@@ -499,23 +499,22 @@
macepci_conf_write(pc, tag, mapreg, *addr);
/* check */
-#ifdef PCIBIOSVERBOSE
- if (!pcibiosverbose)
-#endif
- {
- printf("pci_addr_fixup: ");
- pciaddr_print_devid(pc, tag);
- }
if (pciaddr_ioaddr(macepci_conf_read(pc, tag, mapreg)) != *addr) {
macepci_conf_write(pc, tag, mapreg, 0); /* clear */
+ printf("pci_addr_fixup: ");
+ pciaddr_print_devid(pc, tag);
printf("fixup failed. (new address=%#x)\n", (unsigned)*addr);
return (1);
}
+#ifdef MACE_PCI_DEBUG
#ifdef PCIBIOSVERBOSE
if (!pcibiosverbose)
#endif
+ printf("pci_addr_fixup: ");
+ pciaddr_print_devid(pc, tag);
printf("new address 0x%08x (size 0x%x)\n", (unsigned)*addr,
(unsigned)size);
+#endif
return (0);
}