Subject: Re: Snapshot 20030927 available
To: None <wileyc@rezrov.net>
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
List: port-sgimips
Date: 10/02/2003 00:29:00
In article <20031001062501.GB28311@rezrov.net>
wileyc@rezrov.net wrote:

> > On the other hand, there is the following comment:
> > > /* Remember how the card was setup in case there is no SEEPROM */
> > at line 914 in ahc_pci.c, but the next line is:
> > >	if ((ahc_inb(ahc, HCNTRL) & POWRDN) == 0) {
> > so it does not see ahc->flags to check SEEPROM. Is this really OK?
> 
> I didn't notice that.  Not only is it not checking ahc->flags, but it's
> doing this _before_ it probes for the SEEPROM.

Umm, I didn't notice it... Then, since the comment says _remember_
so it might be intentional to check status before probing SEEPROM.

Anyway, we should ask ahc maintainers (fvdl, gibbs, or bouyer?)
what these code (POWRDN bit etc.) are trying there.
---
Izumi Tsutsui
tsutsui@ceres.dti.ne.jp