Port-prep archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: 40p support broken since 3.99.22?



> If you are using the NetBSD git tree https://github.com/jsonn/src.git ,
> the first broken commit is
>
> commit 82d4758aba7d79da03afd63052e91df33acea97e
> Author: garbled <garbled>
> Date:   Fri Jun 9 01:19:10 2006 +0000
>     Completely rework how we look up PCI interrupts on prep:

Btw, I have a trivial fix for it. But since no one seems to be using
the real 40p machines, I'm not sure how to test it:

diff --git a/sys/arch/prep/prep/machdep.c b/sys/arch/prep/prep/machdep.c
index c59dca3..12cfc57 100644
--- a/sys/arch/prep/prep/machdep.c
+++ b/sys/arch/prep/prep/machdep.c
@@ -277,10 +277,6 @@ cpu_startup(void)
         */
        bus_space_mallocok();
-       /*
-        * Gather the pci interrupt routings.
-         */
-       setup_pciroutinginfo();
 }
 /*
diff --git a/sys/arch/prep/prep/mainbus.c b/sys/arch/prep/prep/mainbus.c
index a189ef8..c591f73 100644
--- a/sys/arch/prep/prep/mainbus.c
+++ b/sys/arch/prep/prep/mainbus.c
@@ -137,6 +137,7 @@ mainbus_attach(struct device *parent, struct
device *self, void *aux)
        SIMPLEQ_INIT(&prep_pct->pc_pbi);
        SIMPLEQ_INSERT_TAIL(&prep_pct->pc_pbi, pbi, next);
+        setup_pciroutinginfo();
        /* find the primary host bridge */
        setup_pciintr_map(pbi, 0, 0, 0);

-----
If you plan to apply the patch, it would probably make sense to rename
 "setup_pciroutinginfo()" to "setup_known_pciintr_quirks()" - that's
what the call actually does.

-- 
Regards,
Artyom Tarasenko

SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu


Home | Main Index | Thread Index | Old Index