Subject: Re: ext_intr thoughts
To: Tim Rightnour <root@garbled.net>
From: Michael Lorenz <macallan@netbsd.org>
List: port-powerpc
Date: 04/27/2007 12:27:21
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hello,
On Apr 27, 2007, at 11:46, Tim Rightnour wrote:
> On 27-Apr-2007 Michael Lorenz wrote:
>> Each method takes a (struct pic_ops *) as first parameter.
>
> If we don't mind having an extra function call in the mix, I think we
> could do
> this, by having ext_intr() just be:
>
> void
> ext_intr(void)
> {
> generic_ext_intr(first_pic);
> }
>
> I think that might be doable.. The struct pic_ops would be defined by
> the
> actual port. Only adjustments I would make is that I don't know if
> the three
> functions you listed are needed in there, rather, we need the three
> get/clear/mask irq functions.
I'd rather have those inlined, even if that means a little code
duplication.
have fun
Michael
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (Darwin)
iQEVAwUBRjIkacpnzkX8Yg2nAQIVPgf5AbXUo4U0ooFr1839YP59crMYpJV099gk
D/6WOuS9WV1WlzKp6AAKVqo888tHmclFbWutDPhDMAgP8aNO5P/g2OZgEAxAu/wM
4ib0ALVmkj3FipJcDjSFARdHBmYvppYjlrPdYBZKJtXudg0fM0MdlNCy128Il6qj
LaAB85F4BAHBwWPhIBAclriKb+IMt2vIT/ZMQrHMUqthmNgdW1wfPJp1ZAp5Zbar
Lw0D0qAh6EMcSbjIGo6Ir+TfX3a4bM6L81Drj1vvgd/pJEnWjqsQ7j4t/82m6HJa
wzpfzLLmM444RZsLEA6p3Pvv2BrqaxQBhwa/SBKQGVad2ejVH8oD0g==
=0Cew
-----END PGP SIGNATURE-----