Subject: Re: A couple of suggestions
To: None <briggs@wasabisystems.com>
From: Derek God3 <derek0godfrey@netscape.net>
List: port-powerpc
Date: 01/06/2004 10:09:59
Whilst we are on it, it would nice if "BOARDTYPE" were more visible
to the build.sh process. Why should my port/board's etc/etc.evbppc/*
distrib/evbppc/*, fdisk or disklabel be the same as somebody else's?
Perhaps subdirectories there would be more manageable - if only
BOARDTYPE were more visible.
-Derek
briggs@wasabisystems.com wrote:
> On Tue, Jan 06, 2004 at 12:37:17PM -0500, Allen Briggs wrote:
>
>>>or CPPFLAGS+=-D__${MACHINE}__
>>
>>I like this. We already define __${BOARDTYPE}__ right now. I'll poke
>>around and try to see where we currently use ${MACHINE} and fix them.
>>The only one that I can think of off-hand is sys/arch/isa/fd.c.
>
>
> Actually, after finding a couple of occurrences in sys/dev, I think
> it would be best to maintain consistency with the other ports that
> define ${MACHINE} and use
>
> CPPFLAGS+=-D${MACHINE}=${MACHINE}
>
> instead.
>
> -allen
>