Subject: Re: Empty bootargs ....
To: None <ws@kurt.tools.de>
From: Andrew Cagney <cagney@tpgi.com.au>
List: port-powerpc
Date: 12/21/1996 09:29:53
Excerpts from netbsd: 19-Dec-96 Re: Empty bootargs .... ws@kurt.tools.de (858*)
> > for (cp = bootpath + strlen(bootpath) + 1; --cp >= bootpath;) {
> Hmm, arguably this isn't unsafe, as the boot code guarrantees that the
> arguments are not empty.
Worse than that, the change above doesn't fix the problem any way :-(
> > o The size argument (r7?) should probably be passed into
> > the function machdep.c:initppc(). That function in turn
> > doing some sort of sanity check.
> Again, the boot code guarrantees that the argument string is indeed one string,
> so this isn't necessary either.
I prefer a more conservative aproach. Don't trust and hence check every
thing at every stage.
enjoy,
Andrew