Subject: Re: mfb patches?
To: None <jonathan@DSG.Stanford.EDU>
From: maximum entropy <entropy@zippy.bernstein.com>
List: port-pmax
Date: 04/09/1997 23:07:32
>From: Jonathan Stone <jonathan@DSG.Stanford.EDU>
>The best way to send in  changes is always to send in a PR.
>That way they don't get overlooked, or lost, or forgotten.

Fair enough.  I guess it's time to re-read the man page for send-pr
and maybe get sendmail running on one of my NetBSD boxes so that I can
actually use it.

>That aside, the changes to the mfb driver you sent aren't yet
>committed because I'm not sure they're completely correct.  The X
>server will need to know that there are only 1280 visible pixels.  

You're right...one of the patches I've been sitting on addresses that
problem (though perhaps not in the cleanest possible fashion).

>I'm guessing, but it seems that changing both the fb descriptors to
>2048 will break that.  I'd also like to fix the screen-saver
>functionality, rather than just disabling it.

I agree that fixing it would be good, but I think it's better to have
a working console and no screen saver rather than a working screen
saver and no console :-)

>Does the patch below  work for you?

I'll try the patch as soon as I get home, but I don't think it's going
to work.  The raster calculations seem to use the fb_width and not the
fi_linebytes data.  But I'll stop speculating for the moment and go
build a kernel.

--
entropy -- it's not just a good idea, it's the second law.