Re: New wsdisplay for playstation2

[al004046%anubis.uji.es@localhost (Jorge Acereda Maciá)]

Matthias Drochner <M.Drochner%fz-juelich.de@localhost> writes:

> al004046%anubis.uji.es@localhost said:
> > gsfb_mmap(void *v, off_t offset, int prot) {
> >     if (GSFB_BUFFER_SIZE >= (unsigned) offset)
> >         return NULL; 
> 
> I didn't look deeper, but this piece of code is wrong for two
> reasons:
> 1. the comparision is reverted
> 2. returning NULL doesn't what you expect - probably you get
>    the physical page at 0 mapped
>    to return an error, use (-1)

Oops, thanks a lot!

BTW, I "inherited" the "return NULL;" from the previous
arch/playstation2/ee/gsfb.c, so I guess it is also buggy.