Subject: Re: generic TODR changes for shark and ofppc
To: Garrett D'Amore <garrett_damore@tadpole.com>
From: =?ISO-8859-1?Q?Jorge_Acereda_Maci=E1?= <jacereda@gmail.com>
List: port-ofppc
Date: 09/13/2006 00:26:29
Garrett D'Amore wrote:
> Jorge Acereda Maciá wrote:
>
>>Garrett D'Amore wrote:
>>
>>
>>>>Attached, find a diff that significantly changes the real-time-clock
>>>>support for shark and ofppc.
>>
>>Now that I look at it, the ofrtc_match() in -current has a bug:
>>
>> if ((l = OF_getprop(oba->oba_phandle, "device_type", type,
>> sizeof type - 1)) < 0 ||
>> l >= sizeof type)
>> return 0;
>>
>> return !strcmp(type, "rtc");
>>
>>That should be strncmp(type, "rtc", 3)
>
>
> Ah, okay. I'll fix it, then. But is it true that there will never be
> a type "rtcXXX" for some other string?
Ok, should be
type[l] = 0;