Port-mips archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

UVM bug in the matt-nb5-mips64 branch



Hi,
playing with the matt-nb5-mips64 branch I ran into a UVM bug:
second_pass is initialized wrongly in uvm_pglistalloc_c_ps() (see attached
patch) which cause it to fail spuriously: if there's no free pages
between hint and end, the code won't look between start and hint before
returning.
With the attached patch things seems to run properly.

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--
Index: uvm_pglist.c
===================================================================
--- uvm_pglist.c        (revision 61)
+++ uvm_pglist.c        (working copy)
@@ -148,7 +148,7 @@
        limit = min(high, ps->avail_end);
        pagemask = ~((boundary >> PAGE_SHIFT) - 1);
        skip = 0;
-       second_pass = true;
+       second_pass = false;
        pgs = ps->pgs;
 
        for (;;) {


Home | Main Index | Thread Index | Old Index