Subject: Re: shared mips softintr code (reviced)
To: None <simonb@wasabisystems.com>
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
List: port-mips
Date: 05/25/2003 19:02:23
Simon, thank you for your comments.

In article <20030525065217.8750353E7F@thoreau.thistledown.com.au>
simonb@wasabisystems.com wrote:

> > I've updated the patch for shared mips softintr code:
> > http://www.ceres.dti.ne.jp/~tsutsui/netbsd/mips-softintr-20030524.diff
 :

> A couple of suggestions:
> 
>  - Call the ipl_si_to_sr array mips_ipl_si_to_sr.

Renamed.
BTW, mips_ipl_si_to_sr[] should be declared in MI or not?

>  - Use softintr_slock in softintr_init and softintr_disestablish
>    (see evbmips for example).  We should also use the simple lock in
>    softintr_dispatch too (see alpha, x86 for example).  I'm not 100%
>    sure if we need _both_ splhigh and the simplelock - it seems that
>    other ports do, but I thought one of the ideas of using locks was
>    that we don't need to use the spl*() calls anymore...

Hmm, I guess these simple_locks are required for SMP support.
I've added them.

> One other minor nit, you don't need to do "#ifdef _KERNEL" if the head
> file (softintr.h) isn't installed in /usr/include.

Ok, I removed it. Newer patch is here:
http://www.ceres.dti.ne.jp/~tsutsui/netbsd/mips-softintr-20030525.diff

I'll commit changes for arc and newsmips later.
---
Izumi Tsutsui
tsutsui@ceres.dti.ne.jp