-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

On Oct 7, 2007, at 09:36, Marco Trillo wrote:

> The attached patch fixes a couple of issues with the snapper(4)  
> driver:
>
>  o In the bass, treble and gain controls, center the 0 dB point at the
> value 128. This is to make them easier to configure and set up
> correctly: the 128 value is the neutral value (so bass/treble/gain is
> disabled -- which is what is desired in many cases). Values higher
> than 128 emphasize bass/treble or add gain; values lesser than 128
> deemphasize bass/treble or add negative gain. Also make 128 the
> default value.

Hmm, I thought it already was that way. At least it was my intention  
when adding bass/treble controls for TAS3004.

> Apart from that, the patch also contains the following general  
> cleanup:
>
>  o Don't hardcode absolute addresses for the FCR registers. Use the
> "baseaddr" parameter passed from obio(4).

Yeah, that had to go away.

>  o Some mixer parameters should be disabled if a "software codec"  
> is used.

Indeed.

> I hope that this is useful!

I'll have a more detailed look later today, thanks for working on this!

have fun
Michael
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)

iQEVAwUBRwkOLMpnzkX8Yg2nAQKMmQgAi3tJEQuyT509VYuZzC5dSYMGO52BlL9e
AxnjhaR7uGW96rneL9DQLCjYi1BBKN7SXv4sTnyksMrcGIHlLxO92hOpshL2UOWS
NkntJX31f0jB9anS+VAEmPBN79iOLPRdlMylcqu2jn+sCrCZQhCRvSf65bjuvEos
LR8QWyiPtGO9eDbl+dGRS8xa/WOjg61NsvM0DA4MQTj+sU6hPTbuCKModSI5gbcu
kBrfQdrMeYwJyt6pZsYRCjmcVKQzccX70mB5vTb3j0H+ibDUPCcK9nsqB67Q8Edq
N6VywAW9IdeagWngKJxZ6xG4/LbiEAB8qTL1vJJXipzBus3XKrqkgg==
=Pant
-----END PGP SIGNATURE-----