On Mon, Oct 30, 2006 at 12:09:57AM +0100, Thomas Klausner wrote:
> It fails with:
> #   compile  installboot/ffs.o
> /build/tools/bin/powerpc--netbsd-gcc -Os -mmultiple -mstring  -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wno-sign-compare -Wno-traditional -Wreturn-type -Wswitch -Wshadow -Wcast-qual -Wwrite-strings -Wextra -Wno-unused-parameter  -Werror   -DNO_FFS_SWAP -I/disk/wd1a/archive/cvs/src/usr.sbin/installboot -I.  -nostdinc -isystem /build/macppc.20061029/usr/include  -c    /disk/wd1a/archive/cvs/src/usr.sbin/installboot/ffs.c
> cc1: warnings being treated as errors
> /disk/wd1a/archive/cvs/src/usr.sbin/installboot/ffs.c: In function 'ffs_find_disk_blocks_ufs1':
> /disk/wd1a/archive/cvs/src/usr.sbin/installboot/ffs.c:156: warning: empty body in an if-statement
> /disk/wd1a/archive/cvs/src/usr.sbin/installboot/ffs.c:172: warning: empty body in an if-statement
> /disk/wd1a/archive/cvs/src/usr.sbin/installboot/ffs.c: In function 'ffs_find_disk_blocks_ufs2':
> /disk/wd1a/archive/cvs/src/usr.sbin/installboot/ffs.c:289: warning: empty body in an if-statement
> /disk/wd1a/archive/cvs/src/usr.sbin/installboot/ffs.c:305: warning: empty body in an if-statement

he@ committed a fix:
Modified Files:
        src/usr.sbin/installboot: ffs.c

Log Message:
In order to avoid warnings (which is converted to error with -Werror)
about empty bodies in an if-statement, we need to make add some proprocessor
conditionals around these if statements.  FFS byte-swapping is sometimes
compiled out of install-media versions of this program.


To generate a diff of this commit:
cvs rdiff -r1.23 -r1.24 src/usr.sbin/installboot/ffs.c

 Thomas