Subject: Re: -current kernel build fails (unofficial patches)
To: Michael <macallan18@earthlink.net>
From: dixie <dixieml@imap.cc>
List: port-macppc
Date: 08/02/2005 14:36:26
Michael wrote:

>Hello,
>
>  
>
>>I was trying to build a 3.99.7 kernel after having applied the patch 
>>supplied by Michael on December 2004 concerning hw sensors (see 
>>http://mail-index.netbsd.org/port-macppc/2004/12/15/0014.html)
>>I've been using that patch since 3.99.5 and all worked fine, now the 
>>build process terminate with some warnings on adt7467.c:
>>    
>>
>
>  
>
>>horus# make
>>#   compile  HORUS/adt7467.o
>>cc -mno-strict-align -msoft-float -Wa,-maltivec -ffreestanding -O2 
>>-Wreturn-type -Werror -Wall -Wno-main -Wno-format-zero-length 
>>-Wpointer-arith -Wmissing-prototypes -Wstrict-prototypes -Wreturn-type 
>>-Wswitch -Wshadow -Wcast-qual -Wwrite-strings -Wno-sign-compare 
>>-fno-zero-initialized-in-bss -Dmacppc=macppc -I. -I../../../../arch 
>>-I../../../.. -nostdinc -DDIAGNOSTIC -DZS_CONSOLE_ABORT 
>>-DOFB_ENABLE_CACHE -DMAXUSERS=10 -D_KERNEL -D_KERNEL_OPT 
>>-I../../../../dist/ipf -c ../../../../arch/macppc/dev/adt7467.c
>>../../../../arch/macppc/dev/adt7467.c: In function `sysctl_adt7467_temp':
>>../../../../arch/macppc/dev/adt7467.c:202: warning: cast discards 
>>qualifiers from pointer target type
>>../../../../arch/macppc/dev/adt7467.c: In function `adt7467c_setup':
>>../../../../arch/macppc/dev/adt7467.c:255: warning: passing arg 4 of 
>>`sysctl_createv' from incompatible pointer type
>>../../../../arch/macppc/dev/adt7467.c:290: warning: passing arg 4 of 
>>`sysctl_createv' from incompatible pointer type
>>*** Error code 1
>>
>>Stop.
>>make: stopped in /usr/src/sys/arch/macppc/compile/HORUS
>>    
>>
>
>Yeah, in the meantime gcc's paranoiac level was considerably increased, I have updated versions that compile, at least here. 
>I'll upload them to ftp://ftp.netbsd.org/pub/NetBSD/misc/macallan/macppc/ in the next few minutes.
>
>have fun
>Michael
>  
>
Uhm, something has changed :)
I unpacked the archive in sys/ and copied deq.c and uni-n.c to
macppc/dev/, adding these lines to my config files:

uni_n*  at mainbus?
ki2c*   at uni_n?                       # Keywest I2C
iic*    at ki2c?                        # attach an I2C bus to each
Keywest. Mainly because we can.
adt7467c*       at ki2c?                # Analog Devices ADT7467 thermal
monitor, fan controller and so on
deq*    at ki2c?                        # mixer/equalizer, needed by snapper

I applied the patch but there was some problems with files.macppc and
config failed:

../../../../arch/macppc/conf/files.macppc:216: attribute `adt7467c'
already defined
../../../../arch/macppc/conf/files.macppc:217: redefinition of `adt7467c'
../../../../arch/macppc/conf/files.macppc:218: redefinition of `adt7467c'
*** Stop.

Then commenting lines 216 to 218 (added by the patch):

# Atheros 5210/5211/5212 Hardware Abstraction Layer (HAL)

#define adt7467c {}
#device adt7467c: sysmon_envsys
#attach adt7467c at ki2c
#file arch/macppc/dev/adt7467.c                 adt7467c

config still failed:

HORUS:529: `adt7467c' cannot attach to `ki2c'
*** Stop.

referring to that line:

adt7467c*       at ki2c?                # Analog Devices ADT7467 thermal
monitor, fan controller and so on

How can I make config rightly aware of the new files and devices?
Are the old .c files and the patch still of any use?
Thank you for your support :)

best regards

d.