Re: CVS commit: src/sys/arch/m68k/conf

["Michael L. Hitch" <mhitch%lightning.msu.montana.edu@localhost>]

On Sun, 6 Jun 2010, matthew green wrote:

> Module Name:    src
> Committed By:   mrg
> Date:           Sun Jun  6 04:51:33 UTC 2010
>
> Modified Files:
>         src/sys/arch/m68k/conf: files.m68k
>
> Log Message:
> fix PR 6724 - convert m68k options to defflag's.  this means that
> M680[12346] are now available from opt_m68k_arch.h.  FPSP meantioned
> in the PR has already been fixed, and i could not find any more.
>
> i built these kernels to ensure i did not break their builds:

  Well, they might build, but that doesn't mean they will run :)

  This change breaks setting the cc and asm flags based on the kernel 
options.  In my case, I was compiling for my 68060, and since none of the 
cpu types was passed to the Makefile, it generated code a multiply that is 
not supported on the 68060, and my kernel crashed with an unimplemented 
instruction trap.  After looking at uvm_pctparam_set() on both my new 
kernel and a working one, I noticed the difference in how the multiply was 
done.  Checking the build of the bad kernel and a log from a previous 
build, I found that the -m68020-60 option was missing.  After a hunt to 
see where that was to come from (src/sys/arch/m68k/Makefile.cmachflags), I 
found that IDENT no longer generated the cpu type flags from the config 
file.  This means we have to go back to explicitly setting the build 
options in the config files in order to generate the correct code, or set 
the appropriate build options outside the kernel build.

--
Michael L. Hitch                        mhitch%montana.edu@localhost
Computer Consultant
Information Technology Center
Montana State University        Bozeman, MT     USA