Subject: Re: CVS commit: src/sys/arch
To: None <thorpej@NetBSD.org>
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
List: port-m68k
Date: 03/11/2007 22:20:41
thorpej@NetBSD.org wrote:

> 	src/sys/arch/m68k/m68k: lock_stubs.s
 :
> - Implement a RAS-based _lock_cas() for mc68010 systems (Sun2).


>> ENTRY_NOPROFILE(_lock_cas)
>> 	movl	%sp@(4),%a0
>>
>>	.globl _C_LABEL(_lock_cas_ras_start)
>> _C_LABEL(_lock_cas_ras_start):
>> 	movl	%a0@,%d0
>> 	cmpl	%sp@(8),%d0
>> 	jne	1f
>> 	movl	%sp@(8),%a0@

Shouldn't this be "movl %sp@(12),%a0@" to store new value?

>> 	.globl	_C_LABEL(_lock_cas_ras_end)
>> _C_LABEL(_lock_cas_ras_end):
>>
>> 	movq	#1,%d0
>> 	rts
>> 1:
>> 	clrl	%d0
>> 	rts
>> #endif /* ! __mc68010__ */
---
Izumi Tsutsui