Subject: Re: NMI on Compaq 1850R
To: Havard Eidnes <he@NetBSD.org>
From: Chris Ross <cross+netbsd@distal.com>
List: port-i386
Date: 01/27/2007 15:47:33
--Apple-Mail-1-497609106
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=US-ASCII;
	delsp=yes;
	format=flowed


On Jan 23, 2007, at 05:47, Havard Eidnes wrote:
>>    Thanks.  One small note.  It's >= "stepping" C0, which is revision
>> 0x03.  Changing either word in the comment you added would make it
>> less confusing.
>
> OK, I reversed the test, and after getting a nudge to commit this
> from a co-developer, that's what I've just done.  Many thanks for
> finding the source of this problem and the fix!

   Please, if someone would be so kind, there is a minor wording  
error in the comment that was added.  If you would be so kind as to  
apply the following patch, I think it's more "correct" of a comment.   
Thanks.

                    - Chris


--Apple-Mail-1-497609106
Content-Transfer-Encoding: 7bit
Content-Type: application/octet-stream;
	x-unix-mode=0644;
	name=pchb.c.diff
Content-Disposition: attachment;
	filename=pchb.c.diff

Index: sys/arch/i386/pci/pchb.c
===================================================================
RCS file: /cvsroot/src/sys/arch/i386/pci/pchb.c,v
retrieving revision 1.63
diff -u -r1.63 pchb.c
--- sys/arch/i386/pci/pchb.c	23 Jan 2007 10:45:33 -0000	1.63
+++ sys/arch/i386/pci/pchb.c	27 Jan 2007 20:42:59 -0000
@@ -196,7 +196,7 @@
 		case PCI_PRODUCT_INTEL_82443BX_NOAGP:
 		/*
 		 * http://www.intel.com/design/chipsets/specupdt/290639.htm
-		 * says this bug is fixed in revisions >= C0 (erratum 11),
+		 * says this bug is fixed in steppings >= C0 (erratum 11),
 		 * so don't tweak the bits in that case.
 		 */
 			if (!(PCI_REVISION(pa->pa_class) >= 0x03)) {

--Apple-Mail-1-497609106--