At Sat, 20 Jan 2007 17:44:20 +0900,
Izumi Tsutsui wrote:

> > Please review the following 2 small patches for AMD Geode LX.
> > (These are tested on NetBSD 3.0.2)
>  :
> >  			{
> >  				"K5", "K5", "K5", "K5", 0, 0, "K6",
> > -				"K6", "K6-2", "K6-III", 0, 0, 0,
> > +				"K6", "K6-2", "K6-III", "Geode LX", 0, 0,
> >  				"K6-2+/III+", 0, 0,
> >  				"K5 or K6"		/* Default */
> >  			},
> 
> Looks okay (AMD docs say Geode LX has CPUID 0x5a2).

Thank you.  I've commited it.

> >  product AMD AMD64_DRAM	0x1102	AMD64 DRAM configuration
> >  product AMD AMD64_MISC	0x1103	AMD64 Miscellaneous configuration
> >  product AMD PCNET_PCI	0x2000	PCnet-PCI Ethernet
> > +product AMD GEODELX_PCHB	0x2080	GeodeLX PCI-Host Bridge
> > +product AMD GEODELX_VGA 	0x2081	GeodeLX VGA Controller
> > +product AMD GEODELX_AES 	0x2082	GeodeLX AES Security Block
> > +product AMD CS5536_PCIB	0x2090	CS5536 PCI-ISA Bridge
> > +product AMD CS5536_OHCI	0x2094	CS5536 OHCI USB Controller
> > +product AMD CS5536_EHCI	0x2095	CS5536 EHCI USB Controller
> > +product AMD CS5536_IDE	0x209a	CS5536 IDE Controller
> >  product AMD PCNET_HOME	0x2001	PCnet-Home HomePNA Ethernet
> >  product AMD PCSCSI_PCI	0x2020	PCscsi-PCI SCSI
> >  product AMD SC520_SC	0x3000	Elan SC520 System Controller
> 
> Maybe it's better to sort entries by product IDs.

Oops,  here is a corrected one.
And a minor change, 'GeodeLX' -> 'Geode LX' (with a space).
Please review again.

--- sys/dev/pci/pcidevs 14 Jan 2007 20:48:53 -0000      1.862
+++ sys/dev/pci/pcidevs 20 Jan 2007 10:43:20 -0000
@@ -873,6 +873,13 @@
 product AMD PCNET_PCI  0x2000  PCnet-PCI Ethernet
 product AMD PCNET_HOME 0x2001  PCnet-Home HomePNA Ethernet
 product AMD PCSCSI_PCI 0x2020  PCscsi-PCI SCSI
+product AMD GEODELX_PCHB       0x2080  Geode LX PCI-Host Bridge
+product AMD GEODELX_VGA        0x2081  Geode LX VGA Controller
+product AMD GEODELX_AES        0x2082  Geode LX AES Security Block
+product AMD CS5536_PCIB        0x2090  CS5536 PCI-ISA Bridge
+product AMD CS5536_OHCI        0x2094  CS5536 OHCI USB Controller
+product AMD CS5536_EHCI        0x2095  CS5536 EHCI USB Controller
+product AMD CS5536_IDE 0x209a  CS5536 IDE Controller
 product AMD SC520_SC   0x3000  Elan SC520 System Controller
 product AMD SC751_SC   0x7006  AMD751 System Controller
 product AMD SC751_PPB  0x7007  AMD751 PCI-PCI Bridge

Thanks in advance.
---
Tetsuya Isaki <isaki@par.odn.ne.jp / isaki@NetBSD.org>