On Sun, Jan 14, 2007 at 12:22:19AM +0100, Juan RP wrote:
> On Sat, 13 Jan 2007 23:43:16 +0100
> Nicolas Joly <njoly@pasteur.fr> wrote:
> 
> > I just tested it on a HP Pavillion 7825, which has a VIA VT86C686A
> > chipset; and i can report that it works (dmesg attached).
> > 
> > In the mean time, i noted a few things:
[...]
> > 2) For consistency with other device descriptions, we should better
> >    use `VIA Technologies' over `VIA' for vendor text.
> 
> Fixed.
> 
> > 3) The same timer does not show the same quality when attached from
> >    ACPI and viaenv.
> > 
> > timecounter: Timecounter "ACPI-Safe" frequency 3579545 Hz quality 900
> > ACPI-Safe 24-bit timer
> > [...]
> > timecounter: Timecounter "viaenv0" frequency 3579545 Hz quality 1000
> > viaenv0 24-bit timer
> 
> Right, I think we could enable the ACPIPMT_BADLATCH flag in
> acpipmtimer_attach() which forces the quality to 900 to be consistent
> with ACPI.

Agreed. But i don't really like this ... It should be better to detect
bad latch in both cases, instead of hard-conding it in viaenv.

-- 
Nicolas Joly

Biological Software and Databanks.
Institut Pasteur, Paris.