Subject: Re: time for INSTALL.ACPI ?
To: Manuel Bouyer <bouyer@antioche.eu.org>
From: Quentin Garnier <cube@cubidou.net>
List: port-i386
Date: 11/22/2006 12:46:44
--niUlcCfh/sMBwTxc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 22, 2006 at 12:34:40PM +0100, Manuel Bouyer wrote:
> On Mon, Nov 13, 2006 at 09:41:35PM +0100, Manuel Bouyer wrote:
> > On Mon, Nov 13, 2006 at 09:15:49PM +0100, Pavel Cahyna wrote:
> > > On Mon, Nov 13, 2006 at 08:46:57PM +0100, Manuel Bouyer wrote:
> > > > On Mon, Nov 13, 2006 at 07:09:29PM +0000, Patrick Welche wrote:
> > > > > Would it be safe to simply switch on acpi in INSTALL?
> > > >=20
> > > > The main problem is that there are some brocken ACPI implementation=
s out
> > > > there (and still some bugs left in our ACPI code I guess). So we re=
ally need
> > > > both ...
> > >=20
> > > Would "disable acpi" in userconf work?
> >=20
> > Hum, maybe. I'll investigate that.
>=20
> OK; I've built a release with the attached diff and tested on 3 different
> systems:
> - recent P4 HT: no problems using ACPI+ioapic, and both can be disabled
>   with boot -c; we get the same dmesg as INSTALL kernel without the patch
> - older P2 system: the kernel finds ACPI but no IOAPIC; the device uses
>   legacy interrupts and are functionnal.
> - a system without ACPI (a Xen HVM guest actually): the kernel prints some
>   messages about not being able to find ACPI and them boots in legacy
>   mode. No problems either.
>=20
> So it looks like adding ACPI+ioapic to INSTALL is workable: on recent sys=
tems
> is should work, on non-acpi one it works; and on sytems where ACPI is bro=
ken
> is should be possible to disable it with boot -c.
> The only problem is that with my patch bootfloppy-big overflows again :(
>=20
> Comments ? Any objection to this change (once a solution for bootfloppy-b=
ig
> is in place) ?

There is one issue:  disabling the acpi device through boot -c doesn't
entirely skip ACPI processing.  acpi_probe() is still called, which does
execute AML code (going through all the _INI methods).  As a consequence,
mpacpi_scan_apics() might be called too.

It's workable, though, using config_search_ia before calling
acpi_probe().

--=20
Quentin Garnier - cube@cubidou.net - cube@NetBSD.org
"You could have made it, spitting out benchmarks
Owe it to yourself not to fail"
Amplifico, Spitting Out Benchmarks, Hometakes Vol. 2, 2005.

--niUlcCfh/sMBwTxc
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (NetBSD)

iQEVAwUBRWQ4pNgoQloHrPnoAQItJAgAwODEzt1a1EWuQLTLep1Z8yl5Cq5wyBAQ
Gxl0PiFRdtkkVrDZeZX3HVcfOgPfFTxCC7G4vJ4OWSuHvRMmC2Y1gkkqwhUS2x9t
Kd+ZmhY4tlt5dYR0xxsCC+wcbulkXSGlpatclpPXMrpQpsRQnJoeYUp9VAskkA/A
TOXh8dEy8jqNa+Or7lYl6L+PhYnJvJIPPlw+4bz9P90rUuiJAAyhhq0fvTvKu0ME
d/lFga68rcp5lWSQGOkEfRIBpSUqvxtWsN51agQ9Sz2CNvPfWCk2cFsJ9yz0f1Ub
tP37HZ1uhUEvqm2OIutN5/L5O6AEWDO0Jl23PAdBoZCl3nq4tG2Eiw==
=PwYz
-----END PGP SIGNATURE-----

--niUlcCfh/sMBwTxc--