Subject: Re: sync i386 pmap with amd64
To: None <>
From: der Mouse <mouse@Rodents.Montreal.QC.CA>
List: port-i386
Date: 07/24/2004 15:20:27
> Could you give a brief description on why the following change is needed?

>       9 -#define        KERNBASE        ((u_long)KERNBASE_LOCORE)
>      10 +#define        KERNBASE        (1UL * KERNBASE_LOCORE)

I didn't write it, but I think it's a good change, even if it may not
be truly "needed".

It has two characteristics I see as generally desirable:

(1) It does not depend on u_long being defined.

(2) It does not narrow the value if it's already wider than long.

Of course, in the context I infer from the names, it's probable neither
of these actually matters, but maintaining good practices even where
not strictly necessary is usually a good idea.

/~\ The ASCII				der Mouse
\ / Ribbon Campaign
 X  Against HTML
/ \ Email!	     7D C8 61 52 5D E7 2D 39  4E F1 31 3E E8 B3 27 4B