Subject: Re: sync i386 pmap with amd64
To: None <>
From: YAMAMOTO Takashi <>
List: port-i386
Date: 07/24/2004 00:31:30

> >
> I'd say I don't like most of it for the following reasons:
> - license complication for no actual benefit.
> - Most of the patch is just to replace "PD" and "PT" with "L2" and "L1",
>   respectively. I'd say "if it ain't broken, don't fix it." for this case.
>   Personally, "PD" and "PT" are easier to read, or at least, less confusing.

actually, there's some benefits.
	- low cost to maintain.  (by sharing code with amd64 eventually)
	- a step to support PAE.

> - why is a single leal instruction replaced with two movl/addl
>   instructions? There are a couple more places with similar changes.

to be similar with amd64 version.
these code isn't worth to optimize, IMHO.

> - have no idea why '1ULL' is replace '1' here. '1' is perfectly fine
>   with the 32-bit world, AFAIK.

1ULL is also perfectly fine.