Subject: Re: ac97 and suspend/resume on laptops
To: Joachim Thiemann <thiemann@gel.usherbrooke.ca>
From: Love <lha@stacken.kth.se>
List: port-i386
Date: 07/15/2004 22:07:54
--=-=-=


Joachim Thiemann <thiemann@gel.usherbrooke.ca> writes:

> patch) and 2) make ac97 driver wait until it can modify the mixer regs 
> before applying the shadow register settings (see ac97.c patch)

I think the codec isn't ready.  With this patch, my IBM T30 (with same
chipset as you have) plays sounds just fine after resume. I also used
include the dont restore reset reg part of your ac97 patch, unclear if that
is really needed.

Love

Index: auich.c
===================================================================
RCS file: /sources/netbsd/NetBSD-cvs/src/sys/dev/pci/auich.c,v
retrieving revision 1.58
diff -u -u -w -r1.58 auich.c
--- auich.c	13 Jan 2004 14:42:50 -0000	1.58
+++ auich.c	15 Jul 2004 19:56:59 -0000
@@ -614,7 +614,7 @@
 
 	for (i = 500000; i >= 0; i--) {
 		status = bus_space_read_4(sc->iot, sc->aud_ioh, ICH_GSTS);
-		if (status & (ICH_PCR | ICH_SCR | ICH_S2CR))
+		if (status & ICH_PCR)
 			break;
 		DELAY(1);
 	}

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (NetBSD)

iQEVAwUAQPbkHXW+NPVfDpmCAQJ5zggAnwS1n47rsJzLJ7Bna51G5PvBvaNvE/Cl
/DfxnlB3nandyEMKfCiWAiN+LP79C4OR5H1kIiGpvEd47fddOjTG2accJkfodXO2
2fAB073U+8X99AWZ2Qq0Paz+nOYbsip2lG9UG3eCvQ6ygR5ujMJlDKTGwTa1TP0o
C3sTO435pB9tPtRr3SWG8nNYhZPTQ9EG8qAF2gEKiqpCQR4Cv2ANREbb/cx7Db/Y
ZlKukaCr5Z/F58NYrKBUMoQuIS+yw4jwVrw1lcHxasRu64lXYyb03Ef6mHSDC391
Irpjr9vcQajN0oQALe6aIc3XFZErtT/VGu2wCFZvLe2vij4Zu7h2+w==
=FXR6
-----END PGP SIGNATURE-----
--=-=-=--