Subject: Re: New ESS Allegro-1 / Maestro3 driver
To: Christoph Kaegi <kgc@zhwin.ch>
From: Antti Kantee <pooka@iki.fi>
List: port-i386
Date: 12/06/2001 14:33:29
On Thu Dec 06 2001 at 12:59:22 +0100, Christoph Kaegi wrote:
> On 2001.09.28 15:47, Jared D. McNeill wrote:
> > I've updated the esa driver (and in the process, LKMized it). It should
> > still work if built into the kernel, although I haven't tested it.
> > 
> > It's available at:
> > 
> >   http://invisible.yi.org/~jmcneill/netbsd/esa-0.1.tar.gz
> > 
> 
> I tried to incorporate the driver into my 1.5.2 kernel today.
> 
> It was surprisingly easy!
> 
> - add entries for esa like those for eap in /usr/src/sys/dev/pci/files.pci
> - copy the esa* files into /sys/dev/pci
> - add "esa*    at pci? dev ? function ?" and
>       "audio*  at esa?" 
>   to my kernel config file
> - config, make depend && make
> 
> and voila: I have sound on my Dell C600 Laptop.

Do you have sound working are suspend+resume also? I never could figure
out do I did wrong, although I think I do exactly the same things as the
linux and FreeBSD drivers (where sound after suspend is rumoured to be
working). FWIW, mine is dell c600 also.

> OK, there were to hickups:
> 
> -------------------------------------- 8< --------------------------------------
> cc  -O2 -Werror -Wall -Wmissing-prototypes -Wstrict-prototypes  -Wpointer-arith -Wno-uninitialized -Wno-main -I. -I../../../../arch -I../../../.. -nostdinc -DSHMMAXPGS="0x400" -DMAXUSERS=32 -D_KERNEL -Di386  -c ../../../../dev/pci/esa.c
> cc1: warnings being treated as errors
> ../../../../dev/pci/esa.c:831: warning: no previous prototype for `esa_pa_match'
> -------------------------------------- 8< --------------------------------------
> 
> Couldn't fix the problem, but compiling without -Werror
> helped.
> What would the correct fix be?

Add a prototype?

int esa_pa_match(struct pci_attach_args *);

-- 
Antti Kantee <pooka@iki.fi>                     Of course he runs NetBSD
http://www.iki.fi/pooka/                          http://www.NetBSD.org/
                   "lyrics. wasted time between solos."