| 1) The region used by the kernel was already eliminated from the map
 |    by putting it in mem_clusters[0] and not probing it.  Your adjust
 |    of mem_clusters[1].size will simply remove the same amount of
 |    memory from the *end* of DRAM bank 0, thereby wasting memory.

DRAM bank0 4M, bank1 16M sample case,

0x0-0x02000000
|knloooo|knloooo|knloooo|knloooo|knloooo|knloooo|knloooo|knloooo|
| 0 | 1 | 0| 
    |<---->|
        a 

0x02000000-0x04000000
|ooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo|
|<---------------------------->|<--- mirror of first 16MByte -->
              2
              b

0x04000000-0x06000000 (the same 0x0-0x02000000)
|knloooo|knloooo|knloooo|knloooo|knloooo|knloooo|knloooo|knloooo|

0x06000000-0x08000000 (the same 0x02000000-0x04000000)
|ooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo|

area a = mem_clusters[mem_cluster_cnt].size = page - startaddr
area 1 = a - start;
area b = area 2 = mem_clusters[mem_cluster_cnt].size = page - startaddr

 | 2) You removed the possibility of supporting 32MB cards by requiring
 |    that there be a `mirror' page.  The test to make sure that the
 |    magic values could be reread should have been sufficient to insure
 |    that we detect the lack of a memory card.

yes.
---
UCHIYAMA Yasushi
uch@nop.or.jp