Subject: Re: Please help with testing jornada patch
To: None <port-hpcarm@NetBSD.org>
From: Valeriy E. Ushakov <uwe@ptc.spbu.ru>
List: port-hpcarm
Date: 02/27/2006 18:25:56
On Mon, Feb 27, 2006 at 15:36:03 +0100, Peter Postma wrote:

> - Battery status is more accurate.

In apm code you need to or in the charging status.  I.e.

    if (j720pwr_get_charge_status(ctx) == 0)
        state |= APM_BATT_FLAG_CHARGING;
              ^^

Oh, and why don't report actual percentage instead of doing in 10%
steps?  (c.f. j6x0pwr)

Thanks.  Great work!

SY, Uwe
-- 
uwe@ptc.spbu.ru                         |       Zu Grunde kommen
http://snark.ptc.spbu.ru/~uwe/          |       Ist zu Grunde gehen