--iytlPraCFSCqrfnM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 21, 2006 at 05:40:16PM +0100, Peter Postma wrote:
> On Tue, Feb 21, 2006 at 05:09:45PM +0100, Quentin Garnier wrote:
> > On Tue, Feb 21, 2006 at 04:22:41PM +0100, Peter Postma wrote:
> > > On Tue, Feb 21, 2006 at 01:07:02PM +0100, Quentin Garnier wrote:
[...]
> > > > The XXX is probably there because of this:
> > > >=20
> > > > if (platid_match(&platid, &platid_mask_MACH_HP_JORNADA_7XX)) {
> > > >=20
> > > > So yes, j720lcd.c does seem to be the correct place.  Otherwise, all
> > > > platforms using that combination of chips would use it.
> > > >=20
> > >=20
> > > Ok, so the XXX indicates that the config hook register should actually
> > > be in j720lcd.c but cannot because then sc !=3D sed1356_softc?
> >=20
> > Well, it could be because it wasn't/couldn't be tested on other similar
> > platforms.
> >=20
> > One thing I don't quite get in your patch though is the extra layer for
> > each objects.  hpckbd should attach directly to j720ssp;  the split in
> > different source files is fine, though.
> >=20
> > Your j720{kbd,lcd,tp} are only avatars of j720ssp, it doesn't make sense
> > to simulate devices at this point.
> >=20
>=20
> I've added the extra layer because the SSP port is part of the SA-1110
> and the keyboard, touch-panel, etc are connected to that port. To me,
> it maked sense to seperate it (the hpcsh port also does similar things).

The reason why hpcsh has j6x0* devices is because they attach to
agnostic devices which are generic for sh3 ports.  They're kind of
place holders, collecting the resources and distributing them to all
their potential children, whoever they are.  j720ssp, on the other hand,
is already specific to the Jornada 720 machine, so it doesn't have to be
agnostic.

--=20
Quentin Garnier - cube@cubidou.net - cube@NetBSD.org
"When I find the controls, I'll go where I like, I'll know where I want
to be, but maybe for now I'll stay right here on a silent sea."
KT Tunstall, Silent Sea, Eye to the Telescope, 2004.

--iytlPraCFSCqrfnM
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (NetBSD)

iQEVAwUBQ/tHl9goQloHrPnoAQKTQAgAhmLtLuj4CuegNN6EWdSnY63ZqudhHag9
r+wPWF8rZob45ix2XmeE4MEnL/gMdxzVGMTYPbxrXJ4WcZgFC4MSA0CyrDh1OjUD
IXpwJ6ujv57an3Hi3q3uj2GsrwVuuvJ8hxUecyl53lE6/O4VYMBkYiqAXwrnO/79
tFMaISfbiv6U7gBJLIL14HJc0uLIqz90gIiVku8Bhytkv18jl97ynZGlho9b1qrK
TCPFK3NSEW4uI9OSv2Trlms2NTYGhVfyTsYSA04jJdQDkMp80+NCUrXOQJ3HgNUC
RtgwHxlui84MDQqZNvNfyigceULsF9VN4TfuCZD8G0tWcDMPWHbp/A==
=5kdP
-----END PGP SIGNATURE-----

--iytlPraCFSCqrfnM--