Subject: Re: RFC: cleaning up j720ssp.c
To: None <port-hpcarm@NetBSD.org>
From: Peter Postma <email@example.com>
Date: 01/17/2006 20:27:54
On Tue, Jan 17, 2006 at 05:51:48PM +0300, Valeriy E. Ushakov wrote:
> On Tue, Jan 17, 2006 at 15:30:21 +0100, Peter Postma wrote:
> > j720ssp.c contains drivers for the touch-panel, keyboard, lcd control
> > and battery status. I'd like to split this into multiple files, because
> > it's a bit messy now and having each driver in a separate file is much
> > cleaner.
> > - j720ssp.c - SSP interface (parent to the above drivers)
> > The last file might possibly be moved to arm/sa11x0/sa11x0_ssp.c
> > (plus some general functions to access it?) because the SSP seems to
> > be part of the SA-1110 according to the Intel docs.
> You can always start with j720ssp.c and move it to arm/sa1100 later.
Ok, that would indeed be the best for now.
> > Also, we might rename j720 to j72x or even j7xx because the 720 is
> > not the only supported model.
> I'm not sure it's necessary. Everyone knows(tm) :) that Jornada 7xx
> series is 720 plus some trivial variations thereof. So it doesn't buy
> much, but disrupts custom configs with device renaming.
True.. Talking about config file changes, my proposal also needs a few
changes to the config file. I hope this is not a big problem.
I'll send patches soon for review.