Subject: Re: RFC: cleaning up j720ssp.c
To: Ignatios Souvatzis <is@netbsd.org>
From: Ignatios Souvatzis <is@netbsd.org>
List: port-hpcarm
Date: 01/17/2006 16:20:09
I wrote:
> On Tue, Jan 17, 2006 at 03:30:21PM +0100, Peter Postma wrote:
> 
> > The last file might possibly be moved to arm/sa11x0/sa11x0_ssp.c (plus some
> > general functions to access it?) because the SSP seems to be part of
> > the SA-1110 according to the Intel docs.
> 
> My favourite nit: You should put the SA1100 stuff into files named
> sa1100*, not sa11x0*

and forgot: "and the SA1110 stuff into files named sa1110*, not sa11x0*",
which is the more important one, as the 720 uses the 1110/1111

	-is


-- 
seal your e-mail: http://www.gnupg.org/