Subject: Re: RFC: cleaning up j720ssp.c
To: None <port-hpcarm@NetBSD.org>
From: Valeriy E. Ushakov <uwe@ptc.spbu.ru>
List: port-hpcarm
Date: 01/17/2006 17:51:48
On Tue, Jan 17, 2006 at 15:30:21 +0100, Peter Postma wrote:

> j720ssp.c contains drivers for the touch-panel, keyboard, lcd control
> and battery status. I'd like to split this into multiple files, because
> it's a bit messy now and having each driver in a separate file is much
> cleaner.

Absolutely.


> - j720ssp.c 	- SSP interface (parent to the above drivers)
> 
> The last file might possibly be moved to arm/sa11x0/sa11x0_ssp.c
> (plus some general functions to access it?) because the SSP seems to
> be part of the SA-1110 according to the Intel docs.

You can always start with j720ssp.c and move it to arm/sa1100 later.


> Also, we might rename j720 to j72x or even j7xx because the 720 is
> not the only supported model.

I'm not sure it's necessary.  Everyone knows(tm) :) that Jornada 7xx
series is 720 plus some trivial variations thereof.  So it doesn't buy
much, but disrupts custom configs with device renaming.


SY, Uwe
-- 
uwe@ptc.spbu.ru                         |       Zu Grunde kommen
http://snark.ptc.spbu.ru/~uwe/          |       Ist zu Grunde gehen