Subject: Re: RFC: cleaning up j720ssp.c
To: None <port-hpcarm@NetBSD.org>
From: Ignatios Souvatzis <firstname.lastname@example.org>
Date: 01/17/2006 15:38:06
Content-Type: text/plain; charset=us-ascii
On Tue, Jan 17, 2006 at 03:30:21PM +0100, Peter Postma wrote:
> The last file might possibly be moved to arm/sa11x0/sa11x0_ssp.c (plus so=
> general functions to access it?) because the SSP seems to be part of
> the SA-1110 according to the Intel docs.
My favourite nit: You should put the SA1100 stuff into files named
sa1100*, not sa11x0* - there's a lot of stuff in there that's different
(unless the specific stuff is compatible, of course).
Same for sa101 / sa1x1 / sa111.
[Does it show that I looked at the j820 again?]
seal your e-mail: http://www.gnupg.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (NetBSD)
-----END PGP SIGNATURE-----