Subject: Re: kernel config file changes
To: Jachym Holecek <freza@psi.cz>
From: Emmanuel Dreyfus <Emmanuel.Dreyfus@espci.fr>
List: port-hpcarm
Date: 06/30/2003 10:22:52
> > ../../../../arch/hpcarm/dev/sed_saip.c:90: #error "define btop, ptob."
> > 
> > Here is the code:
> > 
> > #if defined __mips__ || defined __sh__ || defined __arm__
> > #define __BTOP(x)               ((paddr_t)(x) >> PGSHIFT)
> > #define __PTOB(x)               ((paddr_t)(x) << PGSHIFT)
> > #else 
> > #error "define btop, ptob."
> > #endif
> 
> Hmm, is it OK for code to check against compiler provided macros (see
> below) instead of relying on MACHINE (or whatever kernel-provided value
> appropriate)?

What about just killing this #if? This code will not ever be built for
mips or sh, it is an arm only file.

--
Emmanuel Dreyfus                             
- Quel est le meilleur moyen d'accelerer un PC?
- 9,81 m/s^2
Emmanuel.Dreyfus@espci.fr