Subject: Re: panic on write to ttyS0: Fixed
To: None <manu@netbsd.org>
From: Robert Swindells <rjs@fdy2.demon.co.uk>
List: port-hpcarm
Date: 09/01/2002 23:52:17
Emmanuel Dreyfus wrote:
>> I wonder if this is the cause of the break, it seems a bit too old.
>> Anyone precisely noted when the serial port stopped working?

>Replying to myself :o)

>Ok, the problem was here. When the driver has been moved to the arm32
>directory, there has been a small modification to sacom_filltx().
>Reverting to the old version fixes the panic. I tried the serial port,
>it works well (again), I can use cu to connect to another machine. 

[Fix deleted]

>Now, I'd be happy to commit this change, but I must admit I don't really
>understand what I changed here. Could anyone with a deeper understanding
>of this code tell me if it is okay to commit the above patch? Why I/O
>tag and handle became static variables instead of getting them from
>softc?

Your fix is correct.

The tag and handle weren't deliberately changed to static variables,
the fix to use the values from softc only got put into one of the
copies of sa11x0_com.c.

Robert Swindells