Re: HEADS UP: Merge the gehenna-devsw branch.

[MAEKAWA Masahide <bishop%rr.iij4u.or.jp@localhost>]

Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost> wrote:
>In article <20020915.221346.68532750.bishop%rr.iij4u.or.jp@localhost>
>bishop%rr.iij4u.or.jp@localhost wrote:
>
>> Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost> wrote:
>
>> >It seems that devsw_name2blk() (which is called from
>> >cats/autoconf.c:get_device()) copies wrong strings into
>> >devname arg for the device name. Is the attached patch correct?
>> 
>> it seems to be still wrong. how about this?
>
>I think strncpy will append '\0' if source length is less than
>specified length. The statement "devname[devnamelen - 1] = '\0';"
>is required only if strlen(conv->d_name) is equal or more than
>devnamelen.

ah, yes. you and your patch are right. commit it.

--- MAEKAWA Masahide
--- Key fingerprint = BC5E D8CB 816C 2CB5 8560  FDE3 6CB8 BF5D 8D50 F2EE