Subject: Re: Existing PRs
To: Mike Pumford <mpumford@mpc-data.co.uk>
From: Chris Gilbert <chris@paradox.demon.co.uk>
List: port-arm32
Date: 03/30/2001 23:18:04
On Friday 30 March 2001 10:32 am, Mike Pumford wrote:
> > On Thursday 29 March 2001  9:19 pm, Mike Pumford wrote:
> > > > Actually the patch needs updating before it can be applied to
> > > > current. I have done the mods necessary and the updated patch is
> > > > attached.
> > >
> > > Actually it wasn't but here it is.
> >
> > Ok I'll give it a try this weekend, check my etherm still works, and
> > submit it (unless there's any objections)
> >
> > Is there any reason for the:
> > #ifdef EH500
> > that are sprinkled through the code?  Is that code untested?  Perhaps we
> > should start a list of the #ifdef's we've got sprinkled through the code?
>
> Yes that is non-working code that hopefully will support the Etherlan
> 500 16bit podules. I would just remove that before commiting the code.
> I normally remove it before generating the patches but I forgot this
> time. I can cook a new patch this evening without it.

Don't mind, I'll aim to get to it tommorrow at some point.

Cheers,
Chris