Subject: Re: etherH in NetBSD-current
To: None <port-arm32@NetBSD.ORG>
From: Stefan Voss <voss@yoda.in-berlin.de>
List: port-arm32
Date: 05/05/1997 14:08:13
In message <Pine.SGI.3.95.970509024232.3329A-100000@physig4.ph.kcl.ac.uk>
Mark Brinicombe wrote:
> > >
> > > if ((matchpodule(pa, MANUFACTURER_ICUBED, PODULE_ICUBED_ETHERH, -1) == 0) &&
> > > (matchpodule(pa, MANUFACTURER_ICUBED, PODULE_ICUBED_ETHERHFLASH, -1) ==
> > > 0))
> > > return(0)
> >
> > Shouldn't that be a "logical OR" (||) instead of a "logical AND" (&&)?
>
> matchpodule returns 0 if the match failed so we only want to fail the
> probes if both matches failed. If either one matched i.e. non zero then we
> do not want to return(0).
Argh, of course, matchpodule == 0 is a negative test. You are correct (as
usual). I was misinterpreting "== 0" as a positive test.
I guess I'm doing too much shell scripting ;-)
>
> Cheers,
> Mark
Regards,
Stefan
--
Stefan Voss
(voss@yoda.in-berlin.de)