On Wednesday 20 June 2001  6:48 pm, Robert Swindells wrote:
> Ben Harris wrote:
> >>On Tue, 19 Jun 2001, Chris Gilbert wrote:
> >>
> >> I suppose I'm just looking for consistency and that we don't end up with
> >> a pile of flags just to indicate which platform you're on.
> >
> >Why shouldn't we have such a pile of flags?  I'd certainly prefer
> >
> >if (iomd_id() == IOMD7500)
> >
> >to
> >
> >if (plat == A7000 || plat == NC || plat == MICO || plat == R7500 ||
> >    plat == IBX101)
>
> Arm Linux tests for platform instead of features and ends up rather
> messy as a result.
>
> The biggest problem is when you add a new port, you have to go through
> all the source and add your new platform to the conditional expressions.

Ok I'm convinced, it sounds much saner to test features then.  It just looked 
like a good idea, hence me doing a sanity check by mailing the list rather 
than just doing it :)

Cheers,
Chris