Subject: Re: ADOSFS reading corrupted data
To: None <port-amiga@netbsd.org>
From: Gunther Nikl <gni@gecko.de>
List: port-amiga
Date: 01/24/2003 14:42:22
On Tue, Dec 24, 2002 at 03:15:31AM +0200, Ilpo Ruotsalainen wrote:
> Attached is a more readable version of the patch (I should learn to wait
> until I've slept before posting code...), I've verified that it works on
> 1kb and 4kb blocksize adosfs (FFS variant) filesystems.

  I can confirm that with that patch its again possible to access ados
  partitions with blocksize > 512 bytes (I have only tested 1k though).

> @@ -572,7 +571,7 @@
>  	} else {
>  #ifdef DIAGNOSTIC
>  		printf("flblk offset %ld too large in lblk %ld blk %d\n", 
> -		    flblkoff, bn / (ap->amp->bsize / DEV_BSIZE), flbp->b_blkno);
> +		    flblkoff, bn, flbp->b_blkno);
>  #endif
>  		error = EINVAL;
>  	}

  I wonder how you could compile that. The compiler yelled about the format
  string for me. I think I had to change the second %ld to just %d to get it
  compiled.

  Since nobody commented I wonder if there is no problem? Will that change
  get committed?

  Gunther