Subject: Re: [PATCH] Fixup for Amigas with memory at 0x200000
To: None <aymeric@netbsd.org>
From: Ilpo Ruotsalainen <lonewolf@iki.fi>
List: port-amiga
Date: 01/11/2003 06:18:54
On Sat Jan 11 2003 at 00:11:34 +0100, Aymeric Vincent wrote:
> +LMMUenable_start:
> +
> +/* enable the MMU */
> +#if defined(M68040) || defined(M68060)
> +	RELOC(mmutype, %a0)
> +	cmpl	#MMU_68040,%a0@
> +	jne	Lenable030
> +	.word	0xf518			| pflusha
> +	movl	#0xc000,%d0
> +	.word	0x4e7b,0x0003		| movc	%d0,%tc
> +	jmp	LMMUenable_end:l
> +#endif /* M68040 || M68060 */
> +/* ENABLE, SRP_ENABLE, 8K pages, 8bit A-level, 11bit B-level */
> +Ltc:	.long	0x82d08b00
> +Lenable030:
> +	lea	Ltc,%a0
> +	pmove	%a0@,%tc
> +	jmp	LMMUenable_end:l
> +
> +LMMUenable_end:

This still has the same questionable thing I pointed out in an earlier
mail, on the 030 code path you end up running the "Ltc: .long
0x82d08b00" thing if 060/040 support is not compiled in, and skipping
over it if 040/060 support is compiled in. Seems fishy? If that line is
supposed to be runnable code perhaps a comment should be added
describing the instructions.

...Or perhaps I'm just blind and/or can't read code at this time of the
night...

-- 
Ilpo Ruotsalainen - <lonewolf@iki.fi> - http://www.iki.fi/lonewolf/