Port-amd64 archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: merge bouyer-xenpvh to HEAD



On Sun, Apr 26, 2020 at 01:25:45PM +0200, Maxime Villard wrote:
> In locore.S:
> 
> 	+	movl	$VM_GUEST_XENPV, _C_LABEL(vm_guest)
> 
> vm_guest being an enum, I don't know if the "movl" is correct. The compiler
> could make vm_guest an uint8_t. I think it should be switched to a fixed-
> size type.

Not in C, in C they are int unless the largest enum value forces it to a
larger type.

Joerg


Home | Main Index | Thread Index | Old Index