On 01/03/12 15:27, Christoph Egger wrote:
On 12/16/11 17:57, Christoph Egger wrote:On 12/16/11 17:12, Thor Lancelot Simon wrote:On Fri, Dec 16, 2011 at 04:17:50PM +0100, Christoph Egger wrote:On 12/15/11 18:43, Christoph Egger wrote: kauth(9) is implemented as requested from tls@ and also uses xc_broadcast(9) to automatically apply the ucode patch on all cpus.Thanks! Maybe I am missing this by looking at the patch out of context, but it looks like we're allowing microcode update if "isroot" without reference to securelevel. It seems to me this operation should be allowed only at securelevel< 1. Am I misreading this or is an additional check required?New version attached. Added securelevel check and manpage update.New version attached. Changes: - feedback from wiz@ regarding cpuctl.8 - feedback from jym@: * Changed ENOTSUP to EOPNOTSUPP * Changed __HAVE_CPU_MICROCODE into a kernel config option CPU_UCODE * Moved cpu_ucode_load() into sys/kern_cpu.c Please review.
I want to commit this patch this week. Is it fine? I already have an ok from wiz@ for the manpage only. Christoph