Port-amd64 archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: TESTERS WANTED: audio drivers



> Hi.
> I tested gcscaudio(4) and dreamcast/aica(4), and they work fine.

great news.

> BTW, about esa(4), argument of sys/dev/pci/esa.c:esa_get_locks() is
> struct esa_voice *, not struct esa_softc * ?
> 
> cvs -q diff -au esa.c
> Index: esa.c
> ===================================================================
> RCS file: /cvsroot/src/sys/dev/pci/esa.c,v
> retrieving revision 1.56
> diff -a -u -r1.56 esa.c
> --- esa.c     24 Nov 2011 03:35:59 -0000      1.56
> +++ esa.c     2 Dec 2011 09:02:46 -0000
> @@ -1809,9 +1809,12 @@
>  static void
>  esa_get_locks(void *addr, kmutex_t **intr, kmutex_t **proc)
>  {
> +     struct esa_voice *vc;
>       struct esa_softc *sc;
>  
> -     sc = addr;
> +     vc = addr;
> +     sc = device_private(vc->parent);
> +
>       *intr = &sc->sc_intr_lock;
>       *proc = &sc->sc_lock;
>  }
> 
> 
> Unfortunately I have no esa(4) board, I cannot test.

thanks! this patch looks right.  please commit it.


.mrg.


Home | Main Index | Thread Index | Old Index