Re: NVMe on Alpha

[Rin Okuyama <rokuyama%rk.phys.keio.ac.jp@localhost>]

Hi,

On 2018/09/20 11:59, John Klos wrote:
> I couldn't compile NVMe support on Alpha. Is the lack of pci_intr_setattr due to lack of support on Alpha, or is this something that is only supported on PCIe, not PCI?
>
>
> #      link  HERA/netbsd
> /usr/src/../tools/bin/alpha--netbsd-ld -Map netbsd.map --cref -N -Ttext fffffc0000a00000 -e __transfer -G 4 -X -o netbsd ${SYSTEM_OBJ:[@]:Nswapnetbsd.o} ${EXTRA_OBJ} vers.o swapnetbsd.o
> nvme_pci.o: In function `nvme_pci_intr_establish':
> /usr/src/sys/dev/pci/nvme_pci.c:291: undefined reference to `pci_intr_setattr'
> /usr/src/sys/dev/pci/nvme_pci.c:291: undefined reference to `pci_intr_setattr'
> *** [netbsd] Error code 1

See pci_intr_setattr(9):

  http://netbsd.gw.com/cgi-bin/man-cgi?pci_intr++NetBSD-current

Some architectures, e.g., sparc64, have stubs for it:

  https://nxr.netbsd.org/xref/src/sys/arch/sparc64/dev/pci_machdep.c#387

   387  int
   388  pci_intr_setattr(pci_chipset_tag_t pc, pci_intr_handle_t *ih,
   389                   int attr, uint64_t data)
   390  {
   391
   392          switch (attr) {
   393          case PCI_INTR_MPSAFE:
   394                  return 0;
   395          default:
   396                  return ENODEV;
   397          }
   398  }

But, I don't know whether MP-safe'd drivers work or not with stubs...

Thanks,
rin