Subject: Re: Announce: DEC AlphaServer 8400 is coming
To: Michael L.Hitch <mhitch@lightning.msu.montana.edu>
From: Jason Thorpe <thorpej@shagadelic.org>
List: port-alpha
Date: 07/29/2005 13:42:11
On Jul 28, 2005, at 9:33 PM, Michael L. Hitch wrote:

> That was the culprit.  mlx_enquire() allocates a ccb, allocates and  
> maps a
> buffer an initiates the enquire command.  The handler
> [mlx_periodic_enquiry()] doesn't unmap the buffer.
>
> This patch makes it work:

Nice work.  Please check this in, along with my bus_dma patch.  Once  
I see them hit source-changes, I'll send a pullup request for netbsd-3.

Thanks!

>
> Index: sys/dev/ic/mlx.c
> ===================================================================
> RCS file: /cvsroot/src/sys/dev/ic/mlx.c,v
> retrieving revision 1.33
> diff -u -r1.33 mlx.c
> --- sys/dev/ic/mlx.c    30 May 2005 04:43:47 -0000      1.33
> +++ sys/dev/ic/mlx.c    29 Jul 2005 04:34:32 -0000
> @@ -1121,6 +1121,7 @@
>         u_int lsn;
>
>         mlx = (struct mlx_softc *)mc->mc_mx.mx_dv;
> +       mlx_ccb_unmap(mlx, mc);
>
>         /*
>          * Command completed OK?
>
>
> --
> Michael L. Hitch            mhitch@montana.edu
> Computer Consultant
> Information Technology Center
> Montana State University    Bozeman, MT    USA
>

-- thorpej