Re: wip/munge

[Jason Bacon <jwbacon%tds.net@localhost>]

Done:

Darwin heron bacon ~/Pkgsrc/pkgsrc-1/wip/munge 60: pkglint
looks fine.

Thanks,

     JB

On 4/24/14 3:59 AM, Thomas Klausner wrote:
> On Tue, Apr 22, 2014 at 02:56:15PM -0500, Jason Bacon wrote:
>> Please review wip/munge.  It contains a minor PLIST fix for installing
>> on CentOS Linux.
> It packages fine for me on NetBSD-6.99.40/amd64.
> However, pkglint has quite a number of complaints:
> ERROR: Makefile: Each package must define its LICENSE.
> WARN: Makefile:16: The user-defined variable VARBASE is used but not added to 
> BUILD_DEFS.
> WARN: Makefile:19: "$(VARBASE)/lib/munge" is not a valid pathname.
> WARN: Makefile:19: The user-defined variable VARBASE is used but not added to 
> BUILD_DEFS.
> WARN: Makefile:19: "$(VARBASE)/log/munge" is not a valid pathname.
> WARN: Makefile:19: The user-defined variable VARBASE is used but not added to 
> BUILD_DEFS.
> WARN: Makefile:19: "$(VARBASE)/run/munge" is not a valid pathname.
> WARN: Makefile:19: The user-defined variable VARBASE is used but not added to 
> BUILD_DEFS.
> ERROR: PLIST.FreeBSD:1: "@comment $NetBSD$" expected.
> ERROR: PLIST.Linux:1: "@comment $NetBSD$" expected.
> ERROR: PLIST.NetBSD:1: "@comment $NetBSD$" expected.
> ERROR: patches/patch-src_etc_Makefile.in:3: Comment expected.
> 5 errors and 7 warnings found. (Use -e for more details.)
>
> Can you please fix these?
>
> Thanks,
>   Thomas


-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   Jason W. Bacon
   jwbacon%tds.net@localhost

   Circumstances don't make a man:
   They reveal him.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.  Get 
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review