Re: theama package

[Franck Lesage <francksys%free.fr@localhost>]

Thank you for the reply.

I followed your suggestions and committed the changes.

On Wed, 5 Jun 2013, othyro%safetymail.info@localhost wrote:

> It looks good, mostly. Just a few suggestions:
>
> 1) Use ${MASTER_SITE_SOURCEFORGE:=theama/}
> 2) HOMEPAGE would be better as http://theama.sourceforge.net/
> 3) Your patch hardcodes PDB and it assumes that PREFIX=/usr/pkg. You could 
> use the SUBST framework to fix it, like you're doing with the Makefile, which 
> is quick and easy, although it doesn't fix the problem upstream
>
> ------------------------------------------------------------------------------
> How ServiceNow helps IT people transform IT departments:
> 1. A cloud service to automate IT design, transition and operations
> 2. Dashboards that offer high-level views of enterprise services
> 3. A single system of record for all IT processes
> http://p.sf.net/sfu/servicenow-d2d-j
> _______________________________________________
> pkgsrc-wip-review mailing list
> pkgsrc-wip-review%lists.sourceforge.net@localhost
> https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review
>

------------------------------------------------------------------------------
How ServiceNow helps IT people transform IT departments:
1. A cloud service to automate IT design, transition and operations
2. Dashboards that offer high-level views of enterprise services
3. A single system of record for all IT processes
http://p.sf.net/sfu/servicenow-d2d-j
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review