Re: review request for ifstat and libifstat

[HIRAMATSU Yoshifumi <hiramatsu%jgoamakf.info@localhost>]

Hello,

I looked into libifstat, and noticed two things.

1. When snmp option is enabled, net-snmp needs to be installed.

 .if !empty(PKG_OPTIONS:Msnmp)
 CONFIGURE_ARGS+=        --with-snmp
+.include "../../net/net-snmp/buildlink3.mk"
 .else
 CONFIGURE_ARGS+=        --without-ifmib
 .endif

2. In mail/mutt-devel, SunOS specific CONFIGURE_ARGS is handled in
   Makefile, like this.

.if (${OPSYS} == "SunOS")
CONFIGURE_ARGS+=        --without-wc-funcs
.endif

In my opinion, OS specific CONFIGURE_ARGS in libifstat should be handled
the same way.

At Fri, 29 Mar 2013 23:29:00 +0100,
Florian Geiges <florian%geiges.net@localhost> wrote:
> 
> hi, 
> 
> please review the 'ifstat' and 'libifstat' packages. the 'ifstat' package has 
> been updated to address obvious open issues. both packages build nicely with 
> PKG_DEVELOPER=yes.
> please let me know if any changes are required before these can pass the 
> review stage.
> 
> all the best, 
>     flo

------------------------------------------------------------------------------
Own the Future-Intel(R) Level Up Game Demo Contest 2013
Rise to greatness in Intel's independent game demo contest. Compete 
for recognition, cash, and the chance to get your game on Steam. 
$5K grand prize plus 10 genre and skill prizes. Submit your demo 
by 6/6/13. http://altfarm.mediaplex.com/ad/ck/12124-176961-30367-2
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review